feat!: add close label prop#116
Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom Mar 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for customizing the “Close” button label shown in the integration picker success footer by plumbing a new onCloseLabel prop down to SuccessCardFooter.
Changes:
- Add optional
onCloseLabelprop toHubandIntegrationPicker. - Extend
SuccessCardFooterto acceptonCloseLabeland render it (fallbacking to"Close"). - Remove
onCancelfromHubProps/IntegrationPickerPropsin the updated components.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/modules/integration-picker/IntegrationPicker.tsx |
Accepts onCloseLabel and passes it to the success footer. |
src/modules/integration-picker/components/successCardFooter.tsx |
Renders customizable close button label via onCloseLabel ?? 'Close'. |
src/Hub.tsx |
Adds onCloseLabel to HubProps and forwards it to IntegrationPicker; removes onCancel from props. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
BREAKING CHANGE: onCancel has been removed from StackOneHubProps. Use onCloseLabel to customize the close button label instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jpmiguel
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add optional
onCloseLabelprop toHub,StackOneHub,IntegrationPicker, andSuccessCardFooterto customize the Close button text on success.BREAKING: remove
onCancel(including fromStackOneHubProps); useonCloseLabelto set the label, default remains "Close".Written for commit 02263ff. Summary will update on new commits.