Skip to content

feat!: add close label prop#116

Merged
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:feat-add-close-label-prop
Mar 17, 2026
Merged

feat!: add close label prop#116
adefreitas merged 2 commits intoStackOneHQ:mainfrom
adefreitas:feat-add-close-label-prop

Conversation

@adefreitas
Copy link
Copy Markdown
Collaborator

@adefreitas adefreitas commented Mar 17, 2026

Summary by cubic

Add optional onCloseLabel prop to Hub, StackOneHub, IntegrationPicker, and SuccessCardFooter to customize the Close button text on success.
BREAKING: remove onCancel (including from StackOneHubProps); use onCloseLabel to set the label, default remains "Close".

Written for commit 02263ff. Summary will update on new commits.

Copilot AI review requested due to automatic review settings March 17, 2026 15:13
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for customizing the “Close” button label shown in the integration picker success footer by plumbing a new onCloseLabel prop down to SuccessCardFooter.

Changes:

  • Add optional onCloseLabel prop to Hub and IntegrationPicker.
  • Extend SuccessCardFooter to accept onCloseLabel and render it (fallbacking to "Close").
  • Remove onCancel from HubProps / IntegrationPickerProps in the updated components.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/modules/integration-picker/IntegrationPicker.tsx Accepts onCloseLabel and passes it to the success footer.
src/modules/integration-picker/components/successCardFooter.tsx Renders customizable close button label via onCloseLabel ?? 'Close'.
src/Hub.tsx Adds onCloseLabel to HubProps and forwards it to IntegrationPicker; removes onCancel from props.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

BREAKING CHANGE: onCancel has been removed from StackOneHubProps. Use onCloseLabel to customize the close button label instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@adefreitas adefreitas changed the title feat: add close label prop feat!: add close label prop Mar 17, 2026
@adefreitas adefreitas merged commit f6ceb7e into StackOneHQ:main Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants