-
Notifications
You must be signed in to change notification settings - Fork 59
fix(preview): Preview showing in markdown-only mode #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use node attr to persist toggle
🦋 Changeset detectedLatest commit: 572bec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexwarren
reviewed
Apr 30, 2025
Co-authored-by: Alex Warren <awarren@stackoverflow.com>
threefjefff
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There was a strange bug occurring where if a user refreshed the page when in markdown + preview mode, and then switch first to rich-text mode and finally to markdown only mode, the preview was incorrectly showing.
screen-capture.4.webm
What was happening was that the user's preference was (correctly) setting the default for preview to be true, but the preview visibility toggle was not being triggered when changing from rich-text mode to markdown mode, since they both have preview set to false.
This PR fixes the behavior by always setting the preview visibility when changing editor modes.
PR Checklist
/** ... */docsbug/enhancementand other labels as appropriateEnvironment(s) tested
Additional context
Jira