Skip to content

fix(preview): Fix constant layout shift as preview rerenders #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alizaberger merged 4 commits into from
Mar 7, 2025
Merged

fix(preview): Fix constant layout shift as preview rerenders #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5930c64
Don't clear the preview before rerendering
alizaberger Mar 4, 2025
b1236e5
implement abortController
alizaberger Mar 7, 2025
dd18093
Revert "implement abortController"
alizaberger Mar 7, 2025
ea45a8c
remove spinner stuff
alizaberger Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions site/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,6 @@ const ImageUploadHandler: ImageUploadOptions["handler"] = (file) =>
* NOTE: synchronous renderers can simply return Promise.resolve()
*/
const examplePreviewRenderer: PreviewRenderer = async (content, container) => {
const spinner = document.createElement("span");
spinner.className = "is-loading";
spinner.textContent =
"Intentionally delaying render for example purposes...";
container.appendChild(spinner);

// add a fake load delay (because we can)
await sleepAsync(500);

Expand Down
2 changes: 0 additions & 2 deletions src/commonmark/plugins/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ class PreviewView implements PluginView {

// if showing the preview, fire off the renderer async
if (this.isShown) {
// always clear the preview before re-rendering
this.dom.innerHTML = "";
this.container.appendChild(this.dom);

void this.renderer?.(text, this.dom).catch((e) =>
Expand Down