-
Notifications
You must be signed in to change notification settings - Fork 0
๐::MainMissionView UI ์์ฑ #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gangho0922
wants to merge
62
commits into
develop
Choose a base branch
from
feat/student-main
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
4ef7f49
:bento: Asset ํ์ผ ์ถ๊ฐ
gangho0922 12e57c1
:bento: Asset ํ์ผ ์์
gangho0922 428bb3f
:recycle: ์คํ ์์
gangho0922 e76555f
:bento: Color DesignSystem ์ถ๊ฐ
gangho0922 093449e
:sparkles: LogoNavigationBar ์ถ๊ฐ
gangho0922 9eed38c
:sparkles: MainMissionScrollView ์ถ๊ฐ
gangho0922 89b7bbc
:sparkles: MainRankingView ์ถ๊ฐ
gangho0922 e276139
:sparkles: AppComponent+Order
gangho0922 d5aea42
:lipstick: StudentMainView UI ์์ฑ
gangho0922 b52a04f
Merge branch 'develop' into feat/student-main
gangho0922 0e0e934
:sparkles: StudentMainModel ์์ฑ
gangho0922 3b6351a
:sparkles: StudentMainModelProtocol ์์ฑ
gangho0922 9b8a24b
:recycle: StudentMainView ์ฝ๋ ์์
gangho0922 1cff729
Merge branch 'feat/student-main' of https://github.com/Stack-Knowledgโฆ
gangho0922 2d18367
:fire: ๋ถํ์ ํ์ผ ์ญ์
gangho0922 14fea5d
:sparkles: StudentMainIntent ํ์ผ ์์ฑ
gangho0922 b2d4ff8
Merge branch 'develop' of https://github.com/Stack-Knowledge/Stack-Knโฆ
gangho0922 4fac44e
Merge branch 'develop' of https://github.com/Stack-Knowledge/Stack-Knโฆ
gangho0922 0395bda
:sparkles: AppComponent+Order
gangho0922 59b3cc6
:fire: Main๊ด๋ จ ํ์ผ ์ญ์
gangho0922 a4e768d
:recycle: StudentMain DI ์์
gangho0922 925e2f8
:sparkles: StudentMainModel ์์ฑ
gangho0922 b00648d
:sparkles: StudentMainIntent ํ์ผ ์์ฑ
gangho0922 96a67e2
:sparkles: StudentMainModelStateProtocol ์์ฑ
gangho0922 9061bf5
:sparkles: AppComponent+Order
gangho0922 4dcd8b1
:lipstick: StudentMainView UI ์์ฑ
gangho0922 b49d4f2
:lipstick: SignupListPopupView UI ์์ฑ
gangho0922 fb693eb
:recycle: RootView ์ฝ๋ ์คํ ์์
gangho0922 a63838a
:sparkles: LogoNavigationBar
gangho0922 c6c4022
:sparkles: MainMissionScrollView ์์ฑ
gangho0922 34d0983
:sparkles: MainRankingScrollView ์์ฑ
gangho0922 b650e72
:sparkles: BannerView ์์ฑ
gangho0922 8cc6838
:sparkles: StudentMainIntent
gangho0922 29f1cb0
:sparkles: StudentMainModel
gangho0922 05f2f18
:sparkles: StudentMainModelStateProtocol
gangho0922 e4b7aaf
:recycle: SignupListPopupView ์ฝ๋ ์์
gangho0922 b46eee4
:recycle: SignupListPopupView ์์
gangho0922 e5a8dd5
:recycle: StudentMainView ์ฝ๋ ์์
gangho0922 7eb7734
:recycle: SignupListPopupView ์ฝ๋ ์์
gangho0922 493871a
:truck: SignupListPopupView ์์น ์์
gangho0922 c9705de
:recycle: RaningID ์ถ๊ฐ
gangho0922 cca12d2
:recycle: RankingID ์ถ๊ฐ
gangho0922 c437070
:sparkles: MainMissionScrollView UI ์์
gangho0922 ceec420
:sparkles: MainMissionScrollView UI ์์
gangho0922 a08399b
:sparkles: RankingDataList ์ถ๊ฐ
gangho0922 a0687f1
:recycle: StudentMainView ์ฝ๋ ์์
gangho0922 caa8a71
:memo: ์ถํ์ ์์
ํ ์ฝ๋ ์ถ๊ฐ
gangho0922 e1f2afb
Merge branch 'develop' of https://github.com/Stack-Knowledge/Stack-Knโฆ
gangho0922 786791e
:memo: ํ์ผ ์ด๋ฆ TeacehrTabBar -> TeacherTabBar๋ก ์์
gangho0922 9b577e6
:recycle: MainRankingScrollView ์ฝ๋ ์์
gangho0922 ca2959f
:recycle: MainMissionScrollView ์ฝ๋ ์์
gangho0922 641b4c1
:sparkles: MissionDataList ๋ฐ RankingDataList ์ถ๊ฐ
gangho0922 95c8dd9
:recycle: StudentMainView ์ฝ๋ ์์
gangho0922 c1dbbd0
:recycle: MainRankingScrollView ํ์์๋ ์ฝ๋ ์์
gangho0922 5f7f9cc
:recycle: MainMissionScrollView ํ์์๋ ์ฝ๋ ์์
gangho0922 5ec53fe
:sparkles: StudentMainModel ์์
gangho0922 08144e9
:sparkles: StudentMainModelStateProtocol ์์
gangho0922 6dfc70f
:recycle: StudentMainView ํ์์๋ ์ฝ๋ ์์
gangho0922 a1d4a76
:recycle: SignupListPopupView ํ์์๋ container ์ญ์
gangho0922 70451e4
:recycle: StudentMainView ์ฝ๋ ์์
gangho0922 3243646
:recycle: MainMissionScrollView ์ฝ๋ ๋จ์ถ
gangho0922 c86cc07
:recycle: StudentMainView ํ์์๋ ์ฝ๋ ์ญ์
gangho0922 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
App/Resources/Colors/Medal.xcassets/FirstPlace.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x9B", | ||
| "green" : "0xD7", | ||
| "red" : "0xFF" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x9B", | ||
| "green" : "0xD7", | ||
| "red" : "0xFF" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
App/Resources/Colors/Medal.xcassets/SecondPlace.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xD9", | ||
| "green" : "0xD9", | ||
| "red" : "0xD9" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xD9", | ||
| "green" : "0xD9", | ||
| "red" : "0xD9" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
App/Resources/Colors/Medal.xcassets/ThirdPlace.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x5D", | ||
| "green" : "0x86", | ||
| "red" : "0xCE" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x5D", | ||
| "green" : "0x86", | ||
| "red" : "0xCE" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
6 changes: 3 additions & 3 deletions
6
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+292 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/SKBanner 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+292 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/SKBanner 2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+292 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/SKBanner.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-293 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/banner1 1.png
Binary file not shown.
Binary file removed
BIN
-293 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/banner1 2.png
Binary file not shown.
Binary file removed
BIN
-293 KB
App/Resources/Images/Banner.xcassets/BannerImage_1.imageset/banner1.png
Binary file not shown.
6 changes: 3 additions & 3 deletions
6
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+847 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/SKBanner2 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+847 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/SKBanner2 2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+847 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/SKBanner2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-845 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/banner22 1.png
Binary file not shown.
Binary file removed
BIN
-845 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/banner22 2.png
Binary file not shown.
Binary file removed
BIN
-845 KB
App/Resources/Images/Banner.xcassets/BannerImage_2.imageset/banner22.png
Binary file not shown.
6 changes: 3 additions & 3 deletions
6
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/SKBanner3 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/SKBanner3 2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/SKBanner3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/banner3 1.png
Binary file not shown.
Binary file removed
BIN
-275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/banner3 2.png
Binary file not shown.
Binary file removed
BIN
-275 KB
App/Resources/Images/Banner.xcassets/BannerImage_3.imageset/banner3.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import SwiftUI | ||
|
|
||
| public extension Color.SKColorSystem { | ||
| // swiftlint:disable identifier_name | ||
| enum Medal: SKColorable { | ||
| case firstplace | ||
| case secondplace | ||
| case thirdplace | ||
| } | ||
| } | ||
|
|
||
| public extension Color.SKColorSystem.Medal { | ||
| var color: Color { | ||
| switch self { | ||
| case .firstplace: return StackKnowledgeAsset.Medal.firstPlace.swiftUIColor | ||
| case .secondplace: return StackKnowledgeAsset.Medal.secondPlace.swiftUIColor | ||
| case .thirdplace: return StackKnowledgeAsset.Medal.thirdPlace.swiftUIColor | ||
| } | ||
| } | ||
| } |
45 changes: 45 additions & 0 deletions
45
App/Sources/DesignSystem/Extensions/View/LogoNavigationBar.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import SwiftUI | ||
|
|
||
| struct LogoNavigationBarModifier: ViewModifier { | ||
|
|
||
| var logo: Image = Image(asset: StackKnowledgeAsset.Logo.logoIcon) | ||
| var title: String = "Stack Knowledge" | ||
|
|
||
| func body(content: Content) -> some View { | ||
| content | ||
| .navigationBarBackButtonHidden(true) | ||
| .toolbar { | ||
| ToolbarItemGroup(placement: .navigationBarLeading) { | ||
| HStack { | ||
| logo | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 20, height: 20) | ||
|
|
||
| Spacer() | ||
| .frame(width: 10) | ||
|
|
||
| Text(title) | ||
| .skFont(.r18) | ||
| } | ||
| } | ||
| ToolbarItem(placement: .navigationBarTrailing) { | ||
| Button(action: { | ||
| // logout ๋์ ํ์. | ||
| }) { | ||
| Image(asset: StackKnowledgeAsset.Logout.logoutIcon) | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 24, height: 24) | ||
| .foregroundColor(.primary) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public extension View { | ||
| func logoNavigationBar() -> some View { | ||
| self.modifier(LogoNavigationBarModifier()) | ||
| } | ||
| } |
46 changes: 46 additions & 0 deletions
46
App/Sources/DesignSystem/Extensions/View/MainMissionScrollView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import SwiftUI | ||
|
|
||
| struct MainMissionScrollView: View { | ||
| let title: String = "๋ฏธ์์ค" | ||
| let subtitle: String = "๋ถํํ์๋ถํํ์๋ถํํ์๋ถํํ์๋ถํํ์๋ถํํ์" | ||
| let price: String = "1000 M" | ||
|
|
||
| var body: some View { | ||
| VStack { | ||
| ScrollView(.horizontal, showsIndicators: false) { | ||
| HStack(spacing: 16) { | ||
| ForEach(1..<7) {_ in | ||
| VStack { | ||
| Text(title) | ||
| .skFont(.pm14) | ||
| .multilineTextAlignment(.center) | ||
| .padding(.top, 16) | ||
|
|
||
| Text(subtitle) | ||
| .skFont(.pr12) | ||
| .multilineTextAlignment(.center) | ||
| .lineLimit(3) | ||
| .padding(.top, 16) | ||
| .padding(.horizontal, 16) | ||
|
|
||
| Spacer() | ||
|
|
||
| Text(price) | ||
| .skFont(.pm16) | ||
| .multilineTextAlignment(.center) | ||
| .padding(.bottom, 24) | ||
| } | ||
| .background(Color.white) | ||
| .frame(width: 117, height: 158) | ||
| .cornerRadius(10) | ||
| } | ||
| } | ||
|
|
||
| } | ||
| .padding(.vertical, 16) | ||
| .padding(.horizontal, 15.44) | ||
| .background(Color.SKColorSystem.Gray.lightgray1.color) | ||
| .cornerRadius(20) | ||
| } | ||
| } | ||
| } | ||
73 changes: 73 additions & 0 deletions
73
App/Sources/DesignSystem/Extensions/View/MainRankingView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import SwiftUI | ||
|
|
||
| struct MainRankingView: View { | ||
| let profileName: String = "์๊ฐํธ" | ||
| let ownPoint: String = "1000 M" | ||
|
|
||
| var body: some View { | ||
| VStack { | ||
| ScrollView(.horizontal, showsIndicators: false) { | ||
| HStack(spacing: 15.44) { | ||
| ForEach(1..<4) { i in | ||
|
gangho0922 marked this conversation as resolved.
Outdated
|
||
| ZStack(alignment: .topLeading) { | ||
| VStack { | ||
| Image(.bannerImage3) | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fill) | ||
| .frame(width: 60, height: 60) | ||
| .clipShape(Circle()) | ||
| .clipped() | ||
|
|
||
| Text(profileName) | ||
| .skFont(.pm14) | ||
| .lineLimit(nil) | ||
| .fixedSize(horizontal: false, vertical: true) | ||
|
|
||
| Spacer().frame(height: 16) | ||
|
|
||
| Text(ownPoint) | ||
| .skFont(.pm16) | ||
| } | ||
| .padding(.init(top: 18, leading: 25, bottom: 18, trailing: 25)) | ||
| .background(Color.white) | ||
| .frame(height: 158) | ||
| .cornerRadius(10) | ||
|
|
||
| if i == 1 { | ||
| Circle() | ||
| .frame(width: 20, height: 20) | ||
| .foregroundColor(Color.SKColorSystem.Medal.firstplace.color) | ||
| .overlay( | ||
| Text("1") | ||
| .skFont(.pm14) | ||
| ) | ||
| } | ||
| else if i == 2 { | ||
| Circle() | ||
| .frame(width: 20, height: 20) | ||
| .foregroundColor(Color.SKColorSystem.Medal.secondplace.color) | ||
| .overlay( | ||
| Text("2") | ||
| .skFont(.pm14) | ||
| ) | ||
| } | ||
| else if i == 3 { | ||
| Circle() | ||
| .frame(width: 20, height: 20) | ||
| .foregroundColor(Color.SKColorSystem.Medal.thirdplace.color) | ||
| .overlay( | ||
| Text("3") | ||
| .skFont(.pm14) | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| .padding(.vertical, 16) | ||
| .padding(.horizontal, 15.44) | ||
|
gangho0922 marked this conversation as resolved.
Outdated
|
||
| .background(Color.SKColorSystem.Gray.lightgray1.color) | ||
| .cornerRadius(20) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.