Conversation
erinyoung
approved these changes
Mar 18, 2026
Contributor
|
Tests work |
Contributor
|
I have no changes to recommend. I'm going to get this merged and deployed. |
Contributor
|
Thank you for putting this together so quickly! The status of the deploy can be found at https://github.com/StaPH-B/docker-builds/actions/runs/23258044266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dockerfile for Pangolin 4.4 and pangolin-data 1.38. This new release brings new lineages: https://github.com/cov-lineages/pango-designation/releases/tag/v1.38
I propose we tag this image as
staphb/pangolin:4.4-pdata-1.38and overwrite thelatesttag.Not too different from the previous image, dockerfile only changed by 1 line. Most changes were dependencies installed via micromamba.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)