Merged
Conversation
…d testing the artic-tools binary.
…main commands and examples.
… artic-tools. I'm not sure if I was supposed to do this step, hub.docker.com links and badgen.net links are 404'd.
Contributor
Author
|
First time adding a new tool entry, I hope the README.md and Program_License.md came out correctly, particularly with links to badgen, hub.docker, etc. |
Removed duplicate ARG declaration for ARTIC_TOOLS_VER in Dockerfile.
Contributor
|
Tests work |
Contributor
|
I think this looks good! I made some small changes consolidating the software ARG variable. I do need some confirmation that the get scheme function works without curl being installed before I can approve and merge this. |
…rom builder stage.
Contributor
|
Everything looks like it works |
Updated README.md with additional information and documentation links.
erinyoung
approved these changes
Mar 18, 2026
Comment on lines
+90
to
+91
| RUN apt-get update && apt-get -y install --no-install-recommends \ | ||
| curl |
Contributor
There was a problem hiding this comment.
What does get_scheme use to download primer schemes? I ask because if it uses curl, then curl should be in the app stage.
Contributor
|
Thank you for putting this together! The status of the deploy can be followed here : https://github.com/StaPH-B/docker-builds/actions/runs/23261323038 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Addition of a new tool, artic-tools version 0.3.1. Should include Dockerfile, README.md for v0.3.1, README.md table addition, and Program License update. README.md exceeds 30 lines because the main documentation lacked information on some command requirements and positional arguments; it's supplemented by the output of the help command for each subcommand of artic-tools.