Conversation
build-files/gambit/1.1.0/Dockerfile
Outdated
| LABEL maintainer1="Kevin Libuit" | ||
| LABEL maintainer.email1="kevin.libuit@theiagen.com" |
There was a problem hiding this comment.
Can you adjust LABEL maintainer1 to LABEL maintainer and LABEL maintainer.email1 to LABEL maintainer.email?
There was a problem hiding this comment.
Wait, I thought you wanted me to remove the labels from the app stage haha. I removed all the labels from the app stage. Would you like me to just do it to the top ones?
|
The tests work |
|
I've moved the LABELS to the 'app' stage and fixed maintainer1 to maintainer |
|
Gotcha. Thanks for doing that! I wasn't sure. |
| - python ==3.11 | ||
| - pip | ||
| # Build requirements | ||
| - c-compiler |
There was a problem hiding this comment.
Is the compiler needed at runtime or just when building the software?
There was a problem hiding this comment.
I think just for the software.
|
Sorry about all the failures. I wanted to simplify the ARGs and broke EVERYTHING! Those are now working. This image is missing |
Added code to Install ps (procps) required for Nextflow workflows
|
Okay I updated the code to include ps. I ran the docker build and it ran perfectly: |
|
This image has a lot of compiler software in it. These aren't often used at run time and we can reduce the size of the image if they aren't only installed in the stage where they are used. |
|
Closes #905 |
So would you still like me to attempt to update the docker to remove the extra complier software? I was already on it. |
|
Yes! I'm sorry for the confusion. I'm just linking one of the issue to this PR, so that the issue closes when this PR gets merged |
|
I made some edits to the dockerfile (that I haven't pushed here yet) that brought it down about 50MB: That is small, but better. I think most of the size has to do with the conda env and then the databases. I could mount the databases as a volume at runtime? |
Nevermind! I forgot that mounting required it to be downloaded to my personal machine. Not practical |
|
Tests worked |
| Full documentation: https://gambit-genomics.readthedocs.io/en/latest/ | ||
|
|
||
| GAMBIT (Genomic Approximation Method for Bacterial Identification and Tracking) is a tool for rapid taxonomic identification of microbial pathogens. It uses an extremely efficient genomic distance metric along with a curated database of approximately 50,000 reference genomes (derived from NCBI RefSeq) to identify unknown bacterial genomes within seconds. |
There was a problem hiding this comment.
Could you include all the dependencies installed with micromamba?
There was a problem hiding this comment.
Okay I also just added those!
|
I just merged the app stage! @erinyoung |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Description
Updated gambit to 1.1.0 version from 1.0.0
Diff Output
Test Build