Skip to content

Fix handling of nil values in PII filtering #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iangreenleaf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of nil values in PII filtering #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/workers/occurrences_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def filter_pii_param(param)
when Hash
param.each do |representation, value|
next if %w(language class_name).include?(representation)
param[representation] = filter_pii_string(value)
param[representation] = filter_pii_param(value)
end
end
end
Expand Down
8 changes: 8 additions & 0 deletions spec/lib/workers/occurrences_worker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,14 @@
occ = OccurrencesWorker.new(@params).perform
expect(occ.ivars['email']).to eql('[EMAIL?]')
end

it "should handle nils gracefully" do
@params['ivars'] = {"foo" => { "email" => nil },
"other" => "something"}
expect {
occ = OccurrencesWorker.new(@params).perform
}.not_to raise_error
end
end

it "should stick any attributes it doesn't recognize into the metadata attribute" do
Expand Down