support 4.5 #48
Merged
support 4.5 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naruto
commented
Sep 27, 2025
| { | ||
| m_ResPlayer = resPlayer; | ||
|
|
||
| m_strAnimationSelected.resize(0); |
Collaborator
Author
There was a problem hiding this comment.
- godot 4.5 から rezsize は廃止、clear() が代替
- 一方で godot-cpp 4.5 では resize は現存、 clear はなし
empty string を入れることで両方対応する。
Naruto
commented
Sep 27, 2025
| #ifdef SPRITESTUDIO_GODOT_EXTENSION | ||
| #include <godot_cpp/classes/resource.hpp> | ||
| #include <godot_cpp/classes/resource_loader.hpp> | ||
| #include <godot_cpp/templates/vmap.hpp> |
Collaborator
Author
There was a problem hiding this comment.
4.5 から vmap が廃止、大体として hash_map を利用する。
Naruto
commented
Sep 27, 2025
| // glRotatef( state->uvRotation, 0.0, 0.0, 1.0); | ||
| TranslationMatrix( transMat, uvw + uv_trans.x, uvh + uv_trans.y, 0 ); | ||
| Matrix4RotationZ( rotateMat, state->uvRotation * Math_PI / 180.0 ); | ||
| Matrix4RotationZ( rotateMat, state->uvRotation * 3.1415926535897932384626433833 / 180.0 ); |
Collaborator
Author
There was a problem hiding this comment.
4.4 から Math_PI, 4.5 からは Math::PI となる。
両方対応のため直値で利用する。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.