Allow url adressible version on app page#193
Open
rnwood wants to merge 5 commits intoSplashtopInc:masterfrom
Open
Allow url adressible version on app page#193rnwood wants to merge 5 commits intoSplashtopInc:masterfrom
rnwood wants to merge 5 commits intoSplashtopInc:masterfrom
Conversation
…[id]/[version]) Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
…-selection Add URL addressable version selection on package page
mherrmann
reviewed
Dec 30, 2025
| @@ -0,0 +1,56 @@ | |||
| // Mock API endpoint for testing - returns a list of apps | |||
| export default function handler(req, res) { | |||
| const mockApps = [ | |||
Contributor
There was a problem hiding this comment.
Thanks. I don't think we should duplicate this list of apps (here and in [id].js). If there is such a mock list, then it should only exist once in the code base. That doesn't mean that the list can't be exposed as an API in multiple places though, of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package version selection is now URL addressable via path segments (e.g.,
/apps/7zip.7zip/24.07).Why? I would like to link to apps in your site with specific version selected.
Changes
pages/apps/[id].js→pages/apps/[id]/index.jsand addedpages/apps/[id]/[version].jsfor versioned URLsinitialVersionprop, version selector now updates URL on change, share button includes version pathpages/api/apps/endpoints for local testingBehavior
/apps/7zip.7zip/apps/7zip.7zip/23.01Selecting latest version removes version suffix from URL. Invalid versions show error page.
Screenshots
Default (latest) version:
Older version selected (
/apps/7zip.7zip/23.01):