Attempted to remove double spacing in the install commands#188
Open
DandelionSprout wants to merge 1 commit intoSplashtopInc:masterfrom
Open
Attempted to remove double spacing in the install commands#188DandelionSprout wants to merge 1 commit intoSplashtopInc:masterfrom
DandelionSprout wants to merge 1 commit intoSplashtopInc:masterfrom
Conversation
mherrmann
reviewed
Sep 9, 2025
| const [showingCheck, setShowingCheck] = useState(false); | ||
|
|
||
| let str = `winget install --id=${id} ${version == latestVersion ? "" : `-v "${version}"`} -e`; | ||
| let str = `winget install --id=${id} ${version == latestVersion ? "" : `-v "${version}"`}-e`; |
Contributor
There was a problem hiding this comment.
Thanks. This works when version == latestVersion but I think it will miss the space otherwise.
Contributor
Author
There was a problem hiding this comment.
Probably. I admit I made a bit of a guess on this; the text syntaxing process in SingleApp.js was pretty complicated to figure out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons I can't decisively figure out, there's a double spacing before
-ein the commands that are copied on the packages' Winstall pages, so that for instance copying from https://winstall.app/apps/Rakk.TalanAir results inwinget install --id=Rakk.TalanAir -ewhen having been pasted into PowerShell 7.5.2.So I presumed that this could be a way to fix it.