Merged
Conversation
Add explicit waits for: - The embed modal controller to initialize before clicking Youtube - The input field to be present after Turbo Frame update This prevents race conditions where assertions fire during frame replacement. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1. account_test.rb: Add missing `parts: []` to view_template
- The test was adding a view_template without a :parts key
- This polluted the global theme state causing API serializer
to fail with "undefined method 'map' for nil" when run after
2. editing_pages_test.rb: Remove dependency on YouTube API response
- Don't check for specific video title (requires network call)
- Just verify the embed element was inserted
- Increase wait time to 10s for slower CI environments
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1. test_creating_a_new_page: Add wait: 10 for Publish button - Page creation and redirect can be slow on CI 2. Replace youtube embed test with button embed test - YouTube embed requires network call to oembed API - Button embed has no external dependencies - Still tests the full embed flow: modal, form, insert, save, render Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit waits for:
This prevents race conditions where assertions fire during frame replacement.