Replace active support configurable#1414
Closed
aseroff wants to merge 2 commits intoSpinaCMS:mainfrom
Closed
Conversation
BREAKING CHANGE: calls to `presenter.config.attribute` should be replaced with `presenter.attribute`
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Two instances of ActiveSupport::Configurable inclusions in Spina are raising warnings of upcoming depreciation. Addresses #1413
Changes proposed in this pull request
Replace with mattribute in Spina module and class_attribute in MenuPresenter
Guidance to review
Contains a breaking change: calls to
menu_presenter.config.attributeshould be replaced withmenu_presenter.attribute, or need to add something for reverse-compatibility.