Adds support for gzip and deflate compression#42
Open
mvdwalle wants to merge 2 commits intoSpiderStrategies:masterfrom
Open
Adds support for gzip and deflate compression#42mvdwalle wants to merge 2 commits intoSpiderStrategies:masterfrom
mvdwalle wants to merge 2 commits intoSpiderStrategies:masterfrom
Conversation
Member
|
This seems reasonable to me. Have you been using this branch in your own work? I'd like to see an opt-in approach to this, though. e.g. new Twitter({
consumer_key: '',
consumer_secret: '',
token: '',
token_secret: ''
}, {
gzip: true // defaults to false to prevent any potential breakage.
}) |
Author
|
I chanegd the pull request as suggested. This change is one of a few that we are or want to use internally at my company. |
Member
|
Awesome, thanks! I'd say once you write some tests, we can get this merged. |
|
Any news? Is this still supported? |
Member
|
Module is supported. Waiting on tests for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitter can support gzip compression. I added the option gzip: true to the request and added code to handle either gzip, deflate or none.
I took a quick look at how the tests were set up and I could create tests for this if wanted. But I wanted someone to review first.