-
Notifications
You must be signed in to change notification settings - Fork 295
chore: Hodge Podge to address various CSS inconsistencies - BED-7297 #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7218d0c
9897253
a74b976
6b207cd
5503cb2
2274a16
f8e4bd2
0a8253f
f6d8234
158e3be
8219068
56e595f
e94c3e5
8d3fe59
18485a9
bbb4d8c
e5ce4a0
f22f7e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22337,7 +22337,8 @@ | |
| "Groups", | ||
| "Data Quality", | ||
| "Datapipe", | ||
| "Cypher" | ||
| "Cypher", | ||
| "OpenGraph" | ||
| ] | ||
| }, | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,11 +77,11 @@ const TagDetails: FC<{ tagData: AssetGroupTag; hasObjectCountPanel: boolean }> = | |
| const ownedId = useOwnedTagId(); | ||
|
|
||
| return ( | ||
| <div className='max-h-full flex flex-col gap-8' data-testid='privilege-zones_tag-details-card'> | ||
| <Card className='px-6 py-6 rounded-lg max-w-lg'> | ||
| <div className='max-h-full flex flex-col gap-6 mb-8' data-testid='privilege-zones_tag-details-card'> | ||
| <Card className='p-6'> | ||
| <div className='flex items-center' title={name}> | ||
| {glyph && <ZoneIcon zone={tagData} persistGlyph size={20} />} | ||
| <span className='text-xl font-bold truncate'>{name}</span> | ||
| <span className='text-xl font-bold text-wrap'>{name}</span> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed this to wrap instead of truncate due to the 'basis' classing, allowing it to grow as the window grows / accommodate for larger screens. If a Zone title is long, instead of being truncated, the entire title will show.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| </div> | ||
| {Certification && ( | ||
| <div className='mt-4'> | ||
|
|
@@ -128,8 +128,8 @@ const RuleDetails: FC<{ ruleData: AssetGroupTagSelector }> = ({ ruleData }) => { | |
| const { Certification } = useContext(PrivilegeZonesContext); | ||
|
|
||
| return ( | ||
| <div className='max-h-full flex flex-col gap-8' data-testid='privilege-zones_selector-details-card'> | ||
| <Card className='px-6 py-6 rounded-lg'> | ||
| <div className='flex flex-col gap-6' data-testid='privilege-zones_selector-details-card'> | ||
| <Card className='p-6'> | ||
| <div className='text-xl font-bold truncate' title={name}> | ||
| {name} | ||
| </div> | ||
|
|
@@ -172,10 +172,10 @@ const DynamicDetails: FC<DynamicDetailsProps> = ({ | |
| hasObjectCountPanel = false, | ||
| }) => { | ||
| if (isLoading) { | ||
| return <Skeleton className='px-6 py-6 max-w-lg h-52' />; | ||
| return <Skeleton className='p-6 h-52' />; | ||
| } else if (isError) { | ||
| return ( | ||
| <Card className='px-6 py-6 max-w-lg'> | ||
| <Card className='p-6'> | ||
| <span className='text-base'>There was an error fetching this data</span> | ||
| </Card> | ||
| ); | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows table to grow as a user zooms in and out