refactor(entities): use Entity:GetTable() to store RotorWash
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the lvs_helicopter_rotor.lua entity to use Entity:GetTable() for storing the RotorWashEnt reference instead of direct assignment to self. This change aligns with the codebase's established pattern of using GetTable() for entity data storage, improving performance by reducing table lookups through the metatable chain.
- Replaced
self.RotorWashEntwithEntTable.RotorWashEntin bothCreateRotorWash()andDeleteRotorWash()functions - Added
local EntTable = self:GetTable()at the beginning of these functions to cache the entity table reference - Cleaned up trailing whitespace throughout the modified sections
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.