Conversation
minneee
reviewed
Aug 12, 2025
| var introduction: String | ||
| var strengths: [String] | ||
| var blogLink: String | ||
| var collaborationStyle: [String] |
Collaborator
There was a problem hiding this comment.
피그마에 협업 스타일은 String 형태로 되어있는 상황이라 String으로 변경하는게 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
변경했습니다! 확인 부탁드려요 ~!
Roy-wonji
approved these changes
Aug 12, 2025
Contributor
Roy-wonji
left a comment
Roy-wonji
left a comment
There was a problem hiding this comment.
@Peter1119 코멘트 단거 확인 하시고 한번 확인 해주세요
| } | ||
|
|
||
| // MARK: - 초기 데이터 설정 | ||
| private func setupInitialData(container: ModelContainer) { |
Collaborator
Author
There was a problem hiding this comment.
root view model 생성해서 하자는 말씀이신거죠??
다른 main view model에서 하게 되면
데이터를 넣고 호출하는게 동시에 일어나거나 한 곳에서 일어나서 어색할 것 같아요
minneee
approved these changes
Aug 12, 2025
# Conflicts: # TeamIntroduce/TeamIntroduce/Sources/Presnetaion/IntroduceMain/View/ContentView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
✨ 작업 내용
📸 Showcase
📝 참고 사항
Motivation 🥳 (코드를 추가/변경하게 된 이유)
Key Changes 🔥 (주요 구현/변경 사항)
To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)
Reference 🔗
Close Issues 🔒 (닫을 Issue)
Close #No.
Checklist