Conversation
- 기본 OAuthProviderProtocol을 제공자별 전용 프로토콜로 분리 - Apple, Google 전용 프로토콜 인터페이스 추가 - 생성자 주입을 통한 의존성 주입 방식으로 제공자 업데이트 - 테스트 및 개발을 위한 Mock 구현체 작성 - 제공자 메서드에서 repository 파라미터 제거
Peter1119
approved these changes
Feb 10, 2026
Comment on lines
+15
to
+17
| public final class InMemoryKeychainManager: KeychainManaging, @unchecked Sendable { | ||
| private var accessTokenStorage: String? | ||
| private var refreshTokenStorage: String? |
Contributor
There was a problem hiding this comment.
actor로 사용하지 않으신 이유가 있으신가요 ?
Contributor
Author
There was a problem hiding this comment.
@Peter1119 아 여기 구현하다가 통일을 안해서 여기는 수정 바로 할께요!
Comment on lines
+12
to
+33
| public protocol KeychainManaging: Sendable { | ||
| /// Save access token to keychain | ||
| func saveAccessToken(_ token: String) | ||
|
|
||
| /// Save refresh token to keychain | ||
| func saveRefreshToken(_ token: String) | ||
|
|
||
| /// Save both tokens atomically | ||
| func saveTokens(accessToken: String?, refreshToken: String?) | ||
|
|
||
| /// Load access token from keychain | ||
| func loadAccessToken() -> String? | ||
|
|
||
| /// Load refresh token from keychain | ||
| func loadRefreshToken() -> String? | ||
|
|
||
| /// Load both tokens | ||
| func loadTokens() -> (accessToken: String?, refreshToken: String?) | ||
|
|
||
| /// Clear all stored tokens | ||
| func clearAll() | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
간격 컨벤션 안맞춰진것같은데 흠 .. pre hook에서 swift format 돌리는 것도 좋을 것 같네ㅐ요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes