Merged
Conversation
Peter1119
reviewed
Dec 15, 2025
Contributor
Peter1119
left a comment
Peter1119
left a comment
There was a problem hiding this comment.
고생하셨습니다 ~!
수정하고 한번 더 알려주세요 ~!
Comment on lines
+22
to
+25
| let hasCacheForTab = store.cachedTravelsByTab[store.selectedTab] != nil | ||
| let shouldShowSkeleton = store.isLoading && !hasCacheForTab && store.travels.isEmpty | ||
|
|
||
| return ZStack { |
Contributor
There was a problem hiding this comment.
ZStack background로 변경되면 좋을 것 같고
hasCacheForTab, shouldShowSkeleton은 feature의 계산 프로퍼티로 있어도 될 것 같아요 ~!
Comment on lines
14
to
15
| VStack(alignment: .center, spacing: 0) { | ||
| Image(assetName: "luggage") | ||
| Image(assetName: "emptyTravelList") | ||
| .resizable() |
Contributor
There was a problem hiding this comment.
asset Enum으로 들어가면 좋을 것 같습니다 ~!
Peter1119
approved these changes
Dec 16, 2025
Contributor
Peter1119
left a comment
Peter1119
left a comment
There was a problem hiding this comment.
우선 머지하고 수정하는 방향이 좋을 것 같습니다 ~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용