[Refactor] Firebase Analytics 활성화 및 설정 수정#58
Merged
Conversation
Peter1119
approved these changes
Dec 12, 2025
Comment on lines
+75
to
+94
| // MARK: - Thread Safety Helper | ||
|
|
||
| private class ThreadSafeContainer<T>: @unchecked Sendable { | ||
| private var storage: T | ||
| private let lock = NSLock() | ||
|
|
||
| var value: T { | ||
| lock.withLock { storage } | ||
| } | ||
|
|
||
| init(_ value: T) { | ||
| self.storage = value | ||
| } | ||
|
|
||
| func modify(_ transform: (inout T) -> Void) { | ||
| lock.withLock { | ||
| transform(&storage) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Mock이긴 하지만 actor인데 이게 필요한가요 ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
✨ 작업 내용
📝 참고 사항
Motivation 🥳 (코드를 추가/변경하게 된 이유)
Key Changes 🔥 (주요 구현/변경 사항)
"AppAuth": .framework,
"AppAuthCore": .framework,
"GTMAppAuth": .framework,
"GTMSessionFetcherCore": .framework
"IssueReporting": .framework,
"IssueReportingPackageSupport": .framework,
"XCTestDynamicOverlay": .framework,
"Clocks": .framework,
"ConcurrencyExtras": .framework
To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)
이번 변경으로 다음 문제들이 완전히 해결되었습니다:
특히 packageSettings의 라이브러리 타입 설정이 핵심이므로 이 부분을 중점적으로 검토해주시기 바랍니다.
Reference 🔗
Close Issues 🔒 (닫을 Issue)
OAuth 인증 크래시 이슈 해결