Skip to content

[Feature] Movie Detail UI#19

Merged
Peter1119 merged 4 commits intomainfrom
feature/movie_detail
Oct 17, 2025
Merged

[Feature] Movie Detail UI#19
Peter1119 merged 4 commits intomainfrom
feature/movie_detail

Conversation

@Peter1119
Copy link
Contributor

🔗 관련 이슈


✨ 작업 내용


📸 Showcase

변경 전 변경 후
이미지 이미지
image

📌 이미지가 없다면 이 섹션은 생략해도 됩니다.


📝 참고 사항

Motivation 🥳 (코드를 추가/변경하게 된 이유)

Key Changes 🔥 (주요 구현/변경 사항)

To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)

Reference 🔗

Close Issues 🔒 (닫을 Issue)

Close #No.

Checklist

  • 브랜치를 가져와 작업한 경우 이전 브랜치에 PR을 보냈는지 확인
  • 빌드를 위해 SceneDelegate 수정한 것 PR로 올리지 않았는지 확인
  • 필요없는 주석, 프린트문 제거했는지 확인
  • 컨벤션 지켰는지 확인
  • final, private 제대로 넣었는지 확인
  • 다양한 디바이스에 레이아웃이 대응되는지 확인
    • iPhone SE
    • iPhone 13
    • iPhone 13 Pro Max

@Peter1119 Peter1119 self-assigned this Oct 17, 2025
@Peter1119 Peter1119 added the 🎨 디자인 UI 디자인 작업 label Oct 17, 2025
Copy link
Contributor

@Roy-wonji Roy-wonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peter1119 수고 하셨습니다

} label: {
Text("예매하기")
.frame(maxWidth: .infinity)
.font(.system(size: 16, weight: .bold))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peter1119 뭔가 폰트도 어떤걸 쓸지 저희 정하면 좋을거 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 좋을 것 같아요 !

.font(.system(size: 16, weight: .bold))
.foregroundStyle(Color.white)
.padding(.vertical, 16)
.background(Color.basicPurple)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.foregroundStyle(.white)
.background(.basicPurple)

이렇게 도 수정 할수 있지 않을까요?

Copy link
Contributor

@minneee minneee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

import SwiftUI

struct GenreLabel: View {
let genre: Genre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기만 접근제어자가 빠져있는 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 넵 ! 감사합니다 ~!

@Peter1119 Peter1119 merged commit c3836e7 into main Oct 17, 2025
@Peter1119 Peter1119 deleted the feature/movie_detail branch October 17, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 디자인 UI 디자인 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants