[DO NOT MERGE NOT TESTED] consensusWithdraw proposol#20
Open
roninjin10 wants to merge 3 commits intoSpankChain:masterfrom
Open
[DO NOT MERGE NOT TESTED] consensusWithdraw proposol#20roninjin10 wants to merge 3 commits intoSpankChain:masterfrom
roninjin10 wants to merge 3 commits intoSpankChain:masterfrom
Conversation
Contributor
|
looks good, though I would imagine if you're working with cooperative state you could just keep the channel open and have |
Contributor
|
Agreed. I think all you have to do is |
Author
|
Yea that makes a lot of sense. Then the withdrawal doesn't need to be submitted to chain until right before a consensus close or during a challenge period. |
Author
|
That would allow both parties to continue on without waiting for a confirmation for the new channel to open. |
Author
|
I updated it to keep the channel open as discussed. Currently getting a Stack too deep error though. |
3839bad to
827de18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the idea is we close the channel just like consensus close. But instead of routing the payment to PartyA and PartyI we route some of it to an agreed upon address and route the rest into a brand new channel. This solution means we don't need to change any dispute cases.