Updates to the SpankBank contract v1.2#62
Open
j-h-scheufen wants to merge 12 commits intoSpankChain:v1.2from
Open
Updates to the SpankBank contract v1.2#62j-h-scheufen wants to merge 12 commits intoSpankChain:v1.2from
j-h-scheufen wants to merge 12 commits intoSpankChain:v1.2from
Conversation
…fle.js Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
…e stakes. Refactored checkIn function to allow multiple stakes by the same staker. Renamed function _updateNextPeriodPoints to _applyStakeToCurrentPeriod and modified to calculate points for currentPeriod instead of nextPeriod. Refactored function checkIn to be able to iterate over a defined set of stakes for check-in. Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
…ke now requires the source stake ID as an additional parameter and it allows the receiver to be an existing staker. withdrawStake now requires an array of stake IDs to withdraw which allows withdrawing multiple eligable stakes to be withdrawn in one transaction. Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
…ty now allows claiming booty from multiple periods by specifying a start period. withdrawStake now allows specifying an array of stake IDs and withdrawing all stakes in one transaction. Removed unused and duplicate verify* functions at top of file Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
…be adapted. Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
… structs back to SpankBank.sol as it didn't warrant the extra file. Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
… appropriate test cases to test/spank.js Improved natspec doc in SpankBank.sol Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
…me field that allows all SpankBank rules to rely on timestamps rather than the period numbers. Above all, the Spankbank does not discriminate against early or late stakers; a staker will always commit to a number of periods based on the exact time when the stake was created, before it can be withdrawn. Removed obsolete test/utils.js. Fixed the periodLength in SpankBank.sol to exactly 30 days and removed the constructor parameter. Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
Signed-off-by: Jan Hendrik Scheufen <j.h.scheufen@gmail.com>
j-h-scheufen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the PR:
checkIn,claimBooty, andwithdrawStaketo work with multiple stakes to reduce the number of transactions a staker has to perform. E.g. it is now possible to checkIn on multiple stakes with a single call.increaseStake