-
Notifications
You must be signed in to change notification settings - Fork 23
fix: main.rs, log error #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The error had format w/o argument. The `error` variable was unused.
|
Got that from the AUR package on Arch along some warnings: |
|
Probably caused by this: |
|
Welp, that’s incredibly embarrassing ;-; Sorry for the build error :c Adding ‘learn how pre-commit works’ to my todo |
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
|
@Spagett1 ping |
|
Confirmed this fixes the problems with building on macOS. |
|
Thank you for the patch, I was unaware of master failing to build, appreciate the help and sorry for the delay in merging. |
Thanks. Btw, there is PR #88 that should prevent this type of mistake in the future |
This adds GitHub Actions integration to automatically build (and run tests, should they be added in the future) on Windows, MacOS, and Linux. This will (hopefully) prevent issues like Spagett1gh-87 (introduced by Spagett1gh-83) from recurring in the future. Related-to: Spagett1gh-83, Spagett1gh-86, Spagett1gh-87
The error had format w/o argument. The
errorvariable was unused.