fix: nav links unresponsive during hydration#60
Merged
Conversation
… clicks Nav links were unresponsive for the first few seconds after page load because NuqsAdapter (a client component) wrapped the entire page tree. React 18 captures click events during hydration and replays them only after the full subtree hydrates — heavy page content like GalaxyMap delayed this significantly. Moving Nav and Footer outside lets them hydrate as independent islands.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Nav />and<Footer />outside the<NuqsAdapter>wrapper in the root layoutProblem
Nav header links didn't respond to regular clicks for the first few seconds after page load. Middle-click (open in new tab) worked because it bypasses React's event system. Root cause:
NuqsAdapteris a'use client'component that wrapped the entire page tree. React 18 captures click events during hydration and replays them only after the full subtree hydrates.Test plan