Merged
Conversation
Co-authored-by: Vinh Ngo <vinh.ngo@df.technology> Co-authored-by: Dat Le <dat.le@df.technology> Co-authored-by: Khoa Tran <khoa.tran@df.technology> Co-authored-by: Luu Le <luu.le@df.technology> Co-authored-by: Quynh Nguyen <quynh.nguyen@df.technology>
…ource feat: add license apache 2.0 to source
ngovinh2k2
approved these changes
Jan 22, 2026
|
|
||
| // LoadEventRulesFromDir loads all event rule YAML files from a directory | ||
| // Each file should contain a single device model's rules | ||
| func LoadEventRulesFromDir(dir string) (*EventRulesConfig, error) { |
Member
There was a problem hiding this comment.
Where we will call this function, Dat
Contributor
Author
There was a problem hiding this comment.
When we first start the services anh
Contributor
Author
There was a problem hiding this comment.
I mean at the initialization
| // Get event rules | ||
| e.GET("/event-rules", getEventRules(logger, tsClient)) | ||
| // Create a new event rule | ||
| e.POST("/event-rules", createEventRule(logger, tsClient)) |
Member
There was a problem hiding this comment.
Who will call these APIs, Dat?
Contributor
Author
There was a problem hiding this comment.
Users will call these APIs anh @Quynh-Nguyen
Contributor
Author
There was a problem hiding this comment.
Or other levels like manufacturer or system if there's any further updates.
ngovinh2k2
reviewed
Feb 3, 2026
Quynh-Nguyen
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?
Anything Else?