Full decoding now pulls more data

[fabrouy]

Hey Jason,

I wrote a couple lines. My idea was to return more data when you fully decode a vin number.

• I created a transmission and drivetrain class.
• I updated engine class with more attributes.
• I fixed how colors where pulled (it was only pulling first two array positions) and made a couple changes regarding how the object gets constructed. I wanted to make it easy to access interior and exterior colors.
• Had a similar approach for options.
• I commented out the AS dependency (could not make it work with it, is it necessary?)
• I updated the exception class, I think keys where wrong.
• Updated sanitization. It failed for me when tried to basic decode because some of the params (that are passed to the request object when full decoding) where not initialized.

Tests for this are missing, but check it out, let me know what you think.

Regards,

[Sovietaced]

@fabrouy Sorry for the dumb question but is this the result of a more recent API change?

[fabrouy]

I'm not sure if it was different in the past. Right now doing .map over colors just loops over a couple of keys (interior and exterior) not the actual colors.

[Sovietaced]

OK. I'm fine with that as long as the test works out fine.

[Sovietaced]

@fabrouy I'm finally taking a look at this now. Let me see if I can get my local dev environment going..

[Sovietaced]

so this is used in the request.rb class

require 'active_support/core_ext/hash'

When I bundle it fails to install but I know I have it... I'm confused.

[Sovietaced]

I fixed this up on master.

[Sovietaced]

@fabrouy Once you fix the merge conflicts, you should be able to run all the tests locally! Things are no longer broken as the build is passing.

[Sovietaced]

This looks reasonable.

[Sovietaced]

If you add another commit, travis ci should build the pull request.

[Sovietaced]

@fabrouy Do you want me to take over this PR?

[fabrouy]

Sure! Very bussy lately unfortunately.