JMPEntry Wrapper class and small re-write#11
Merged
SomeJakeGuy merged 31 commits intomainfrom Jan 2, 2026
Merged
Conversation
Owner
SomeJakeGuy
commented
Jan 2, 2026
SomeJakeGuy
commented
- JMPEntry wrapper class, which allows JMPEntries to be updated/get values as a true dictionary using field_name, field_hash, or the JMPHeaderField itself.
- Added a JMPFieldHeader equality method and a proper hash function.
- Privatized data_entries and introduced some new functions to add and delete entries.
- Added a function to remove JMPFieldHeaders. Will automatically remove from all data_entries for you.
- Created/merged from find_jmp_header functions.
- Introduced some unit-tests to check JMP read/writes are successful.
- Updated/Added various docstrings.
…ar the fields property. Additionally, moved find functions up a few as well.
…he key from all entries as well.
…using JMPEntry class instead.
…rying to be added.
…rscore in its name.
…g entries and headers.
…MP that would otherwise break previous implementation.
…eld_hash input. Created an update function as well.
… into one private function.
…s later for automated testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.