FIT-54: Populate products table with data#57
Open
PiotrMichalak1 wants to merge 2 commits intomainfrom
Open
Conversation
database/prod-changelog.yml
Outdated
| - include: | ||
| file: common-changelog.yml | ||
| - include: | ||
| file: scripts/006-FIT-54-create_user_and_fill_products_table_with_initial_data.sql No newline at end of file |
Collaborator
There was a problem hiding this comment.
what if we had 3 different environments with 3 different sets of data we want to use on each?
Collaborator
Author
There was a problem hiding this comment.
I didn't like this solution either. I succeeded in leveraging liquibase contexts to put all changesets in one changelog.
Please look at this with caution as it was a trial an error process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found out that there was no validation for products with too long names. Added lacking validation and test.