Remove unknown file warning from read_annotations()#169
Merged
scheidec merged 2 commits intoSomaLogic:mainfrom Feb 12, 2026
Merged
Remove unknown file warning from read_annotations()#169scheidec merged 2 commits intoSomaLogic:mainfrom
scheidec merged 2 commits intoSomaLogic:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes version/checksum-based validation from read_annotations() to eliminate misleading “unknown annotations file” warnings, and updates docs/tests/versioning accordingly.
Changes:
- Simplified
read_annotations()to always read the “Annotations” sheet with a fixedskip = 8L, removinggetAnnoVer(),ver_dict, andtools::md5sumusage. - Updated documentation and examples to reflect the new expectations for annotation files.
- Adjusted test coverage and bumped the development version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
R/read-annotations.R |
Removes version/checksum logic and simplifies read/validation behavior. |
tests/testthat/test-read-annotations.R |
Drops tests for removed version/checksum features; adds column presence checks and updates error expectation. |
man/read_annotations.Rd |
Updates parameter description and example filename to match new assumptions. |
NEWS.md |
Documents the removal of restrictive validation and dependency cleanup. |
NAMESPACE |
Removes tools::md5sum import. |
DESCRIPTION |
Bumps package version to a dev version. |
README.md |
Updates the version badge to match the dev version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- removed md5sum checksum validation and version dictionary checks resulting in warnings of unknown annotations files - warning was often misleading, as menu annotations file updates are not always in alignment with timing of CRAN releases - removed `getAnnoVer()` function and `ver_dict` object - updated documentation to reflect more flexible file requirements - removed `tools::md5sum` import dependency
8ab2336 to
095c305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
md5sumchecksum validation and version dictionary checksresulting in warnings of unknown annotations files
not always in alignment with timing of CRAN releases
getAnnoVer()function andver_dictobjecttools::md5sumimport dependency