Skip to content

Remove unknown file warning from read_annotations()#169

Merged
scheidec merged 2 commits intoSomaLogic:mainfrom
scheidec:rm-annots-file-warning
Feb 12, 2026
Merged

Remove unknown file warning from read_annotations()#169
scheidec merged 2 commits intoSomaLogic:mainfrom
scheidec:rm-annots-file-warning

Conversation

@scheidec
Copy link
Copy Markdown
Contributor

  • removed md5sum checksum validation and version dictionary checks
    resulting in warnings of unknown annotations files
  • warning was often misleading, as menu annotations file updates are
    not always in alignment with timing of CRAN releases
  • removed getAnnoVer() function and ver_dict object
  • removed tools::md5sum import dependency
  • bump to development version

@scheidec scheidec requested a review from Copilot February 12, 2026 20:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes version/checksum-based validation from read_annotations() to eliminate misleading “unknown annotations file” warnings, and updates docs/tests/versioning accordingly.

Changes:

  • Simplified read_annotations() to always read the “Annotations” sheet with a fixed skip = 8L, removing getAnnoVer(), ver_dict, and tools::md5sum usage.
  • Updated documentation and examples to reflect the new expectations for annotation files.
  • Adjusted test coverage and bumped the development version.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
R/read-annotations.R Removes version/checksum logic and simplifies read/validation behavior.
tests/testthat/test-read-annotations.R Drops tests for removed version/checksum features; adds column presence checks and updates error expectation.
man/read_annotations.Rd Updates parameter description and example filename to match new assumptions.
NEWS.md Documents the removal of restrictive validation and dependency cleanup.
NAMESPACE Removes tools::md5sum import.
DESCRIPTION Bumps package version to a dev version.
README.md Updates the version badge to match the dev version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- removed md5sum checksum validation and version dictionary checks
  resulting in warnings of unknown annotations files
- warning was often misleading, as menu annotations file updates are
  not always in alignment with timing of CRAN releases
- removed `getAnnoVer()` function and `ver_dict` object
- updated documentation to reflect more flexible file requirements
- removed `tools::md5sum` import dependency
@scheidec scheidec force-pushed the rm-annots-file-warning branch from 8ab2336 to 095c305 Compare February 12, 2026 21:13
@scheidec scheidec merged commit fbc5bf4 into SomaLogic:main Feb 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants