fix: Make spawn process work on Windows #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslabbinck
approved these changes
Apr 8, 2025
Collaborator
woutslabbinck
left a comment
woutslabbinck
left a comment
There was a problem hiding this comment.
Test script still works on my machine, so this change ensure ODRL evaluator can work with local eye on both windows and linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would make my life easier.
The Windows installation of eye is done with a batch file, which requires this setting as noted in https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
I also changed the eye path in the test to
eyefrom/usr/local/bin/eyeso it is platform independent. Or does that break stuff for you?