Generic dialog to create new request by laska-sl · Pull Request #22 · SoftwareCountry/arcadia-teams-bot

laska-sl · 2020-04-25T11:18:32Z

No description provided.

ArcadiaTeamsBot/Dialogs/MainDialog.cs

sponkrashin · 2020-05-10T10:44:43Z

ArcadiaTeamsBot/Dialogs/MainDialog.cs

        }

-        public static HeroCard GetChoiceCard()
+        private static HeroCard ChoiceCard()


Method name should contain verb.

sponkrashin · 2020-05-10T19:38:09Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+                return false;
+            }
+
+            if (formData["Button"].ToString() == Cancel)


Constant instead of magic string.

Constant added

sponkrashin · 2020-05-10T19:39:17Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+            for (var i = 6; i < additionalFieldsData.Count; i++)
            {
-                GetInfoCard().ToAttachment()
+                additionalFieldsValues.Add(additionalFieldsData[i].Last.ToString());


What is type of additionalFieldsData[i]?

sponkrashin · 2020-05-10T19:39:38Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

-            return await stepContext.PromptAsync(nameof(TextPrompt),
-                new PromptOptions
+
+            if (string.IsNullOrEmpty(formData["Title"].ToString())


Constant added

sponkrashin · 2020-05-10T19:40:15Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+
+            var createRequestTypeFields =
+                (await this.mediator.Send(new GetServiceDeskRequestTypesQuery(), cancellationToken))
+                .First(requestTypeDTO => requestTypeDTO.Id == Convert.ToInt32(formData["TypeId"].ToString()))


Constant added

sponkrashin · 2020-05-10T19:40:50Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+            }
+
+            var createRequestTypeFields =
+                (await this.mediator.Send(new GetServiceDeskRequestTypesQuery(), cancellationToken))


Move getting of request type fields to separate method.

sponkrashin · 2020-05-10T19:41:06Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+
+            var newRequest = new CreateRequestDTO
+            {
+                Title = formData["Title"].ToString(),


Constant added

sponkrashin · 2020-05-10T19:47:30Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+                switch (field.FieldType)
+                {
+                    case RequestTypeUIFieldType.Year:
+                        textBlock = new AdaptiveTextBlock("Enter a year");


Year of what? A field name should be added somewhere.

sponkrashin · 2020-05-10T19:50:03Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+            var promptOptions = new PromptOptions
+            {
+                Prompt = (Activity)MessageFactory.Attachment(InputFormCard(cardBody, Actions)),
+                RetryPrompt = MessageFactory.Text("Not all fields are filled. Repeat")


Where is it used?

sponkrashin · 2020-05-10T19:59:54Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

            {
-                Title = "In Development",
-                Buttons = new List<CardAction>
+                return await stepContext.ReplaceDialogAsync(nameof(MainDialog), null, cancellationToken);


Probably, it is better to send user to previous dialog instead of main dialog in such case.

sponkrashin · 2020-05-11T16:54:44Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+            };
+        }
+
+        private static Attachment InputFormCard(List<AdaptiveElement> body, List<AdaptiveAction> actions)


Where is verb?

sponkrashin · 2020-05-11T17:00:36Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+        private const string Cancel = "Cancel";
+        private const string Yes = "Yes";
+        private const string No = "No";
+        private const string Button = "Button";


I suppose it should be the same as property name in line 200. In that case you'd better introduce new private interface like interface IButtonData { string Button { get; set; } } and use nameof(IButtonData.Button). Then you will never forgot to change value in one place after changing in another.

sponkrashin · 2020-05-11T17:05:06Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+
+                new AdaptiveTextInput { Id = TypeId, Value = requestTypeDTO.Id.ToString(), IsVisible = false },
+
+                new AdaptiveTextBlock(Title),


You don't need to use constants everywhere or at least you need to separate constants used for ids to prevent misprints when accessing form values from constants used to show user in UI.
You use title of text block and it's input placeholder only here, you don't need to access them later from anywhere - thus you don't have to use constant.

sponkrashin · 2020-05-11T17:05:41Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+        private const string Description = "Description";
+        private const string ExecutionDate = "Execution Date";
+        private const string Username = "ekaterina.kuznetsova@arcadia.spb.ru";
+        private readonly IRequestTypeUIFactory requestTypeUIFactory;


Please, add empty line between constants and fields.

sponkrashin · 2020-05-11T17:09:15Z

ArcadiaTeamsBot/Dialogs/NewRequestDialog.cs

+        private async Task<bool> ValidateForm(PromptValidatorContext<string> promptContext, CancellationToken cancellationToken)
        {
-            var attachments = new[]
+            var formData = (JObject)promptContext.Context.Activity.Value;


You use same code thrice - to validate, in choice step and to get final values. It could be better to create internal class which will represent form data and return parsed form values from a method.

Duveshka and others added 22 commits April 13, 2020 11:31

something

66ac32e

merge with develop

90e7ef6

add input form

113de0f

Show additional fields according to their fieldTypes

fe6aac1

Add empty buttons

f69721a

add waterfall input data

30559e8

Some changes

633f043

Code-style fixes. Fixed convertions

75b8423

Almost added additional fields

0a0997a

Send to SD without additional fields

84722f0

Some fixes

500c7d1

More changes

c811b20

Back to input form. Send without additional fields

0a86075

For instead foreach

fbc7ab7

Add choice step

4a2ecea

delete unnecessary lines

93adc8b

Awesome output strings. More readable code

d29a507

Fixed sending request priority

bb82494

Fixed DTOs for creation

06c789b

Changed hardcoded output string

84d2184

Added "Back" button and from validation

61a5546

Check if user enter spam instead of filling the form

18309f6

laska-sl requested review from Duveshka and sponkrashin April 25, 2020 11:18

laska-sl assigned laska-sl and Duveshka Apr 25, 2020

laska-sl linked an issue Apr 25, 2020 that may be closed by this pull request

Add generic dialog for each type of Service Desk request #8

Open

laska-sl changed the title ~~Generic dialog~~ Generic dialog to create new request Apr 25, 2020

laska_sl added 2 commits April 26, 2020 11:37

Refactoring and cleaning

20cedd0

Hid Service Desk settings

e866326

sponkrashin changed the base branch from develop to feature/dialog-with-requests-types April 27, 2020 02:37

sponkrashin changed the base branch from feature/dialog-with-requests-types to develop April 27, 2020 02:41

Merge Requests types

e6224eb

Duveshka changed the base branch from develop to feature/dialog-with-requests-types April 27, 2020 12:13

Duveshka added 2 commits April 29, 2020 12:21

Rename fields

111c734

Merge with dev

4e006b5

Duveshka changed the base branch from feature/dialog-with-requests-types to develop April 29, 2020 11:19

Duveshka and others added 6 commits April 29, 2020 14:49

Change static fields

f6be495

Classes access modifiers fixes

b0b43cb

R# configuration changes

4fdcce1

Code formatting

052c153

Renamed variable to avoid coleasing

1c6153f

Added message about successfuly added request

f2c712d

sponkrashin reviewed May 3, 2020

View reviewed changes

ArcadiaTeamsBot/Dialogs/MainDialog.cs Outdated Show resolved Hide resolved

Duveshka added 2 commits May 6, 2020 14:36

Fix additional fields from input

889a4cb

DI injection

3896920

sponkrashin suggested changes May 10, 2020

View reviewed changes

Duveshka added 2 commits May 10, 2020 18:29

Change choice step

9deb06f

Fix button cancel

8f53d39

sponkrashin suggested changes May 10, 2020

View reviewed changes

Duveshka added 4 commits May 10, 2020 23:30

Add constants

cbaeaeb

Add separate method

4958cb8

Change input form

7fad9ec

Change priorities

21e12ea

sponkrashin reviewed May 11, 2020

View reviewed changes

Duveshka added 4 commits May 11, 2020 20:51

Rename something

fba1482

change button

fe7304a

Add internal class

035d19a

String Method

77c218b


		new AdaptiveTextInput { Id = TypeId, Value = requestTypeDTO.Id.ToString(), IsVisible = false },

		new AdaptiveTextBlock(Title),

Conversation

laska-sl commented Apr 25, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants