fix(package-env): improve Windows npm version detection #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
reviewed
Dec 17, 2025
| const quotedCmd = `\`${agent} ${FLAG_VERSION}\`` | ||
| debugFn('stdio', `spawn: ${quotedCmd}`) | ||
| try { | ||
| let stdout: string |
Collaborator
There was a problem hiding this comment.
should this be limited to windows?
jdalton
reviewed
Dec 17, 2025
billxinli
force-pushed
the
fix/windows
branch
from
b266e3f to
7094748
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
billxinli
force-pushed
the
fix/windows
branch
from
0b38102 to
db60bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix a bug where Socket CLI fails to detect npm version (socket optimize blocked) on windows.
Windows 11 + Powershell
Windows 11 + cmd
OSX
Note
Improve npm version detection on Windows by resolving shims/JS entrypoints and add targeted tests.
src/utils/package-environment.mts).cmdshim fornpmwhen paths are absolute and extensionless.resolveBinPathSync; if it’s a JS file (.js/.cjs/.mjs), run via Node with--version; otherwise spawn directly (withshellon Windows).npmalongsidenodeand fallback towhichBinretained.test/package-environment.npm-version.test.mts)Written by Cursor Bugbot for commit b266e3f. Configure here.