Open
Conversation
SoJeongMun
requested review from
HerrineKim,
cheonkyu0,
raymondanythings and
ydw1996
HerrineKim
approved these changes
Mar 15, 2023
Collaborator
There was a problem hiding this comment.
styled-components 같은 CSS-in-JS에 대해 어떻게 생각하시나요? 저는 처음 리액트를 쓸 때 써보면서 오히려 파일 별로 관리하는 게 중복이 많이 일어난다는 생각이 들었는데요. 테일윈드랑 비교해서 어떠신지 궁금해요!
cheonkyu0
approved these changes
Mar 20, 2023
Collaborator
raymondanythings
left a comment
raymondanythings
left a comment
There was a problem hiding this comment.
스타일쪽 변화가 많은 것 같네요! 내일 작동하는거 실제로 볼 수 있으면 좋을 것 같아요
raymondanythings
approved these changes
Mar 20, 2023
cheonkyu0
reviewed
Mar 26, 2023
| console.log(doc.data()) | ||
| }) | ||
| setMySweet(queryResult.docs.map((doc) => doc.data())) | ||
| const mySweets = queryResult.docs.map((doc) => ({ |
Collaborator
There was a problem hiding this comment.
직전 코드 보다는 좋습니다.
추가적으로 optional 만 더 해주면 더 좋아보입니다.
cheonkyu0
approved these changes
Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ PR 체크리스트
PR 타입
설명하실 변경 사항은 어떤 종류인가요?
이슈 번호 : #8
해당 PR이 프로젝트에 큰 영향이 있나요?
작업 내용
추가 설명