Skip to content

Fix: Mitigate YAML Deserialization Vulnerability #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoClosee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Mitigate YAML Deserialization Vulnerability #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions core/business_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from typing import Dict, List, Optional, Callable

import yaml
from yaml.loader import SafeLoader

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -50,8 +51,8 @@ def reload(self):
for f in self.projects_dir.glob("*.yaml"):
try:
new_mtimes[str(f)] = f.stat().st_mtime
with open(f) as fh:
data = yaml.safe_load(fh) or {}
with open(f, 'r') as fh:
data = yaml.load(fh, Loader=SafeLoader) or {}
if data and data.get("project", {}).get("enabled", True):
projects.append(data)
except Exception as e:
Expand Down Expand Up @@ -197,7 +198,7 @@ def add_project(
},
}

with open(filepath, "w") as f:
with open(filepath, 'w') as f:
yaml.dump(data, f, default_flow_style=False, sort_keys=False)

self.reload()
Expand All @@ -207,8 +208,8 @@ def delete_project(self, name: str) -> bool:
"""Delete a project by name. Returns True if found and deleted."""
for f in self.projects_dir.glob("*.yaml"):
try:
with open(f) as fh:
data = yaml.safe_load(fh) or {}
with open(f, 'r') as fh:
data = yaml.load(fh, Loader=SafeLoader) or {}
if data.get("project", {}).get("name", "").lower() == name.lower():
f.unlink()
self.reload()
Expand All @@ -232,8 +233,8 @@ def get_project_filepath(self, name: str) -> Optional[str]:
"""Get the YAML file path for a project."""
for f in self.projects_dir.glob("*.yaml"):
try:
with open(f) as fh:
data = yaml.safe_load(fh) or {}
with open(f, 'r') as fh:
data = yaml.load(fh, Loader=SafeLoader) or {}
if data.get("project", {}).get("name", "").lower() == name.lower():
return str(f)
except Exception:
Expand Down