Skip to content

Fix potential security vulnerability in BrowserManager #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoClosee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix potential security vulnerability in BrowserManager #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions freework_scraper/scraper/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
"""Cross-platform Selenium browser manager for FreeWork scraper."""

from __future__ import annotations

import logging
import platform

Expand All @@ -14,30 +10,30 @@

logger = logging.getLogger(__name__)


class BrowserManager:
"""Manages Selenium Chrome browser lifecycle — Windows, Mac & Linux."""

def __init__(self, headless: bool = True):
self.headless = headless
self.driver: webdriver.Chrome | None = None

def start(self) -> webdriver.Chrome:
"""Start Chrome browser with optimal settings."""
options = self._build_options()
service = Service(ChromeDriverManager().install())

logger.info("Launching Chrome (headless=%s) on %s...", self.headless, platform.system())
self.driver = webdriver.Chrome(service=service, options=options)
try:
logger.info("Launching Chrome (headless=%s) on %s...", self.headless, platform.system())
self.driver = webdriver.Chrome(service=service, options=options)

if not self.headless:
self.driver.maximize_window()

if not self.headless:
self.driver.maximize_window()
logger.info("Browser started successfully.")
except Exception as e:
logger.error("Error starting browser: %s", e)
raise

logger.info("Browser started successfully.")
return self.driver

def _build_options(self) -> Options:
"""Build Chrome options for cross-platform compatibility."""
options = Options()

# Core stability flags
Expand Down Expand Up @@ -76,20 +72,17 @@ def _build_options(self) -> Options:
return options

def get(self, url: str) -> None:
"""Navigate to a URL."""
if not self.driver:
raise RuntimeError("Browser not started. Call start() first.")
self.driver.get(url)

@property
def page_source(self) -> str:
"""Get current page HTML source."""
def page_source(self) -> str:
if not self.driver:
raise RuntimeError("Browser not started.")
return self.driver.page_source

def quit(self) -> None:
"""Safely close the browser."""
if self.driver:
try:
self.driver.quit()
Expand All @@ -104,4 +97,4 @@ def __enter__(self) -> BrowserManager:
return self

def __exit__(self, *args) -> None:
self.quit()
self.quit()