Merged
Conversation
Contributor
Author
|
@SnosMe - would it be possible to just merge this in? That would save me the tedious work of having to rebase once in a while. You don't have to address the Mac bugs and can just @ me for them and I can take a look. |
Contributor
Author
SnosMe
reviewed
Dec 8, 2022
hsource
added a commit
to hsource/electron-overlay-window
that referenced
this pull request
Dec 9, 2022
Per a comment in SnosMe#29 , this added line doesn't seem necessary, as the `this.events.on('focus'` handler should get called immediately after, which does the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
I wanted to get awakened_poe_trade working on Mac, and this was the biggest barrier, since no binaries existed for this on Mac.
PS: thanks a lot for the great demo app! I don't think developing this would've been possible without that
Fix
Created Mac interface for overlay_window.h - for the most part, this is structured similarly to the Windows/Linux code, with a few exceptions:
Side changes
Testing
Tested by:
yarn demo:electronattachByTitlein the electron-demo file to attach to a window with a different titleTested
Resizing, focusing
Fullscreen
Screen.Recording.2021-05-28.at.3.13.07.AM.mp4