fix(enable_assoc): prevent AttributeError and remove dead code#27
Open
CoderFX wants to merge 2 commits intoSniffleupagus:mainfrom
Open
fix(enable_assoc): prevent AttributeError and remove dead code#27CoderFX wants to merge 2 commits intoSniffleupagus:mainfrom
CoderFX wants to merge 2 commits intoSniffleupagus:mainfrom
Conversation
- Replace bare `except Exception` with `except ImportError` for Touch_UI import - Replace deprecated `logging.warn()` with `logging.warning()` - Fix double space typo in __description__ - Add consistent [Enable_Assoc] prefix to all log messages - Remove trailing semicolons - Use logging.warning for errors instead of logging.info - Simplify on_ui_update to use str() - Remove redundant pass statement - Bump version to 1.0.1
- Initialize self._ui = None in __init__ to prevent AttributeError if on_webhook is called before on_ui_setup - Remove unused `method` and shadowed `path` variables in on_webhook - Fix logging.exception() usage (pass message string, not exception) - Remove unused Touch_Screen import - Remove empty on_touch_press handler (only logged debug) - Fix on_ui_update indentation/comment alignment - Bump version to 1.0.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self._ui = Nonein__init__to preventAttributeErrorifon_webhookis called beforeon_ui_setupmethodand shadowedpathvariables inon_webhooklogging.exception()usage (pass message string, not exception object)Touch_Screenimporton_touch_presshandleron_ui_updateindentationBuilds on #25. Related to #23.