Fix: 40w laser crosshair offset when Run from Luban#2586
Open
AlmirKadric wants to merge 1 commit intoSnapmaker:mainfrom
Open
Fix: 40w laser crosshair offset when Run from Luban#2586AlmirKadric wants to merge 1 commit intoSnapmaker:mainfrom
AlmirKadric wants to merge 1 commit intoSnapmaker:mainfrom
Conversation
added moduleOriginOffset feature to machine definitions and setup a default crosshair offset
Author
|
Will address some of the issues in #2377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the required custom G-Codes (M2003 and M2004) which offset the 20w & 40w lasers to align their crosshairs, are not implemented on the controller side. This results in the jobs using the 20w & 40w lasers to be shifted to the right when "Run from Luban". When checking the controller (LCD panel), there was a section in the laser configuration for these values and it is being handled correctly when a G-Code file is run directly from the controller (LCD).
To temporarily alleviate this issue, I introduced a moduleOriginOffset feature which enables us to define module specific origin offsets within the machine definition files. I also introduced a new module definition for the crosshair so that it can ben controlled from the machine settings window. Lastly I hardcoded a default crosshair offset.
Potential Improvements: