Modified installation to entry_points to support python2 and python3 correctly#10
Open
NJDFan wants to merge 3 commits intoSnaipe:masterfrom
Open
Modified installation to entry_points to support python2 and python3 correctly#10NJDFan wants to merge 3 commits intoSnaipe:masterfrom
NJDFan wants to merge 3 commits intoSnaipe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took advantage of the setuptools entry_points functionality to make the installer install correctly on both python2 and python3. This also took adding
from __future__ import print_functionto fully support py2. Also, since the new installation relies on setuptools features not available in distutils I removed distutils from the list of legal imports.Testing in a python2 virtualenv and a python3 venv, Ubuntu 16.04 only.