Fix debugging on macOS and add fallback debug method #421
Conversation
|
I've also added a new section to the documentation about debugging on macOS. |
MrAnno
force-pushed
the
fallback-idledebug-and-macos-debugserver
branch
from
325e584 to
223e0f6
Compare
|
@Snaipe debugbreak is currently broken on Apple silicon, but their development branch is 1 commit ahead of the previous release, containing a fix for our problem: https://github.com/scottt/debugbreak/commits/master Can I bump the submodule to point to the mentioned commit? |
|
It seems there is an issue with the mentioned debugbreak commit, it won't work when compiling with GCC on macOS: A bugfix proposal is already provided in the above issue. |
|
I don't mind using non-tagged commits, be it there or on forks. To be fair we could probably vendor it ourselves here too; we already do this with valgrind. |
MrAnno
changed the title
|
Let's see what happens with scottt/debugbreak#25. I'll try to "vendor" the change after waiting a few days. |
MrAnno
force-pushed
the
fallback-idledebug-and-macos-debugserver
branch
from
d501d5a to
2f0450a
Compare
|
LGTM; could you add a ChangeLog entry for the fix? |
Support macOS "debugserver" and fallback "idle" debug method
…ound This is done only when no specific debugger type is specified by the user.
The following contribution fixes a gcc compilation issue on macOS: scottt/debugbreak#25 This commit replaces the upstream repo with a fork until the above PR gets integrated into the upstream master.
Apple silicon support
MrAnno
force-pushed
the
fallback-idledebug-and-macos-debugserver
branch
from
2f0450a to
af870a1
Compare
Snaipe
left a comment
Snaipe
left a comment
There was a problem hiding this comment.
LGTM, two nits on the changelog but other than that feel free to merge once these are fixed
|
I really don't like doing this, but I temporarly replaced debugbreak with a fork. The forked repo contains 2 small patches on top of the upstream's master, which fixes a compilation issue on macOS with a real gcc compiler. Those 2 patches have been contributed back to upstream (scottt/debugbreak#25), hopefully, they will be integrated soon. I think fully bundling debugbreak is not worth it currently, as there are plenty of improvement possibilities on ARM devices, and it would be easier to follow those future changes with submodules. |
MrAnno
force-pushed
the
fallback-idledebug-and-macos-debugserver
branch
from
af870a1 to
1cc3911
Compare
|
Using a fork is fine. Criterion had to use a special fork of nanomsg for years with some changes to make it fork-safe until BoxFort was introduced, it can live with a fork of debugbreak for a while. |
|
Thank you. |
2 participants
--debugnow uses the official macOSdebugserverby default (if it's onPATH)--debugwill fall back to theidlemethod in case no debugger can be foundDepends on Snaipe/BoxFort#36
Fixes #420