making version a setting that is configured in mpesa.php#57
Open
dedanirungu wants to merge 2 commits intoSmoDav:masterfrom
Open
making version a setting that is configured in mpesa.php#57dedanirungu wants to merge 2 commits intoSmoDav:masterfrom
dedanirungu wants to merge 2 commits intoSmoDav:masterfrom
Conversation
Author
|
You have made an update to only reference v1. what about we make it configurable to cover both v1 and v2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues working with EndPoint.php because it is reference v1 for some URLs and v2 for other URLs at the same time.
I have changed it to have a configuration that can be set at mpesa.php and used in EndPoint.php to load the required version.