Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 15, 2026

Addresses review feedback from PR #11 by adding comprehensive documentation to the Logger utility.

Changes

  • LogLevel documentation: Added KDoc explaining each severity level (DEBUG for diagnostics, INFO for lifecycle events, WARN for potential issues, ERROR for failures)
  • Extension function documentation: Added KDoc for convenience methods d(), i(), w(), e() clarifying they are shorthand for log() with specific LogLevel

Example Usage

// Platform-agnostic logging across Android, JVM, and WasmJs
Logger.d("MyTag", "Debug message")
Logger.e("NetworkClient", "Request failed: ${error.message}")

The JVM implementation already routes WARN and ERROR to System.err as suggested in the review.

Note: iOS Logger implementation will be added separately by the maintainer.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: SmilingPixel <73827509+SmilingPixel@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx4096M -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.3-bin/cv11ve7ro1n3o1j4so8xd9n66/gradle-8.14.3/lib/gradle-daemon-main-8.14.3.jar (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add platform-specific Logger implementations for cross-platform use Add iOS Logger implementation and KDoc documentation Jan 15, 2026
Copilot AI requested a review from SmilingPixel January 15, 2026 02:05
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not have to implement iOS Logger -- just leave it to me. I would add it laterly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed iOS Logger implementation in commit 3057994. The KDoc documentation for LogLevel enum and extension functions remains in place.

Copy link
Owner

@SmilingPixel SmilingPixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on file. iOS logger implementation is not required.

@SmilingPixel SmilingPixel marked this pull request as ready for review January 15, 2026 02:29
Co-authored-by: SmilingPixel <73827509+SmilingPixel@users.noreply.github.com>
Copilot AI changed the title Add iOS Logger implementation and KDoc documentation Add KDoc documentation for Logger Jan 15, 2026
Copilot AI requested a review from SmilingPixel January 15, 2026 02:33
@SmilingPixel SmilingPixel merged commit 2fbaf6c into feat/logging_0112 Jan 15, 2026
1 check passed
@SmilingPixel SmilingPixel deleted the copilot/sub-pr-11 branch January 15, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants