-
Notifications
You must be signed in to change notification settings - Fork 0
Add KDoc documentation for Logger #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: SmilingPixel <73827509+SmilingPixel@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not have to implement iOS Logger -- just leave it to me. I would add it laterly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed iOS Logger implementation in commit 3057994. The KDoc documentation for LogLevel enum and extension functions remains in place.
SmilingPixel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on file. iOS logger implementation is not required.
Co-authored-by: SmilingPixel <73827509+SmilingPixel@users.noreply.github.com>
Addresses review feedback from PR #11 by adding comprehensive documentation to the Logger utility.
Changes
d(),i(),w(),e()clarifying they are shorthand forlog()with specific LogLevelExample Usage
The JVM implementation already routes WARN and ERROR to
System.erras suggested in the review.Note: iOS Logger implementation will be added separately by the maintainer.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.