added support for CaravanBonusSpeedFactor from equipment#314
Open
tectin0 wants to merge 1 commit intoSmashPhil:developfrom
Open
added support for CaravanBonusSpeedFactor from equipment#314tectin0 wants to merge 1 commit intoSmashPhil:developfrom
CaravanBonusSpeedFactor from equipment#314tectin0 wants to merge 1 commit intoSmashPhil:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively low-effort pull request, as I don't actually know much about RimWorld modding or the Vehicle Framework codebase. I wanted to address an issue where equipment-based caravan speed bonuses (specifically from "Bundle of Trinkets" mod) are ignored once a pawn enters a vehicle. Please feel free to close this and implement a "proper" version if this doesn't meet the framework's standards.
Tested using the "Nautical Compass" from Bundle of Trinkets on a Longship from Alpha Vehicles - Age of Sail. The bonus applied correctly once the pawn boarded.
Known Issue: Because this uses
AllPawnsAboard, the speed bonus only appears once the pawns are physically inside the vehicle. It does not currently reflect the bonus during the initial "Form Caravan" planning stage before the pawns have boarded (if the pawn isn't already inside). Maybe you know an immediate fix for that.Thanks for the incredible work on the framework!
(I also used the
release/1.6as a base because I couldn't make anything compile on thedevelopbranch - don't know if that changes anything)