Add option to disable YouTube video preview #195
Conversation
|
Thanks, I'll add it later as it may be useful for some people, but I don't think it's the root cause of your issue as embeds are only loaded on demand since 2.23.1 when I replaced them with just cover image. Would you mind filing issue with more details like your browser version, OS, maybe sample troublesome channels if you can notice any difference and possibly hardware so I can have some context? |
|
You're right it may not be the main issue that causes a huge resource consumption, but as the Task Manager marks it as "VIdeo Decode" that was my first idea. My browser version is the latest Edge version 95.0.1020.30 on Windows 10 20H2. I can reproduce this very high consumption of the GPU every time I refresh the feeds. It stays like this until I either close the browser or kill the GPU thread in the browser internal task manager. |
|
Do your patch cause the load to drop resource usage? Would you mind sharing list of your sources as I can't reproduce this issue with mine and there's nothing obvious in the code? |
|
I have setup a new browser (Microsoft Edge Version 96.0.1047.2 (Official build) dev (64-bit)) with the built extension, imported all my feeds using OPML and configured it the same way as my main browser. I have then decided to clean the trash in the extension and after a while (this view was really slow) I was able to get only 50% GPU usage. Now after cleaning most of it it's down to near 0. If you want to reproduce I would guess that adding a lot of fake articles to the trash would allow you to trigger it after a refresh, but it doesn't make sense to me. Thanks for your help. |
|
What number would you consider to be "a lot"? Currently I have something in range of 600-800 of items in trash in my Edge profile and can't see any issue, though I'll leave it running overnight and see if anything changes in that matter |
|
I did not see any count so I cannot say, but I believe it was between 10k and 100k. I don't believe you can replicate it without creating fake items, naturally you would have to be waiting a few months with a hundred feeds. I guess I had the issue by not cleaning up the trash after almost a year of usage. |
|
Currently I got to somewhere around 7k, I added some pretty active feeds, including automatically generated fake feed and few Youtube channels posting over 10 videos a day to get at least some idea what is happening, for now I see no indication of any load being put on the video decoder and the 3D block drops to 0 as soon as interface changes stop, though rendering the articles list takes a while if I decide to look into the trash as there's no virtual scrolling. That being said, keeping this amount of items is probably a bad idea also due to the memory consumption, the architecture of this extension keeps complete copy of the store in memory (which is one of reasons it won't be able to work with Manifest v3 and I really don't have enough time to work on it) |
|
Update: so I'm probably at around 15k and started noticing Video Decode and the GPU load doesn't go down after feed loading finishes, it still makes no sense to me but it happens. Then I proceeded to export subscription data (the SMART file) and import it in Vivaldi and Brave, the issue didn't happen there, then cleaned the extension data in Edge and imported again, issue happened again. It looks like Edge does something weird and unexpected in these conditions, unfortunately I don't have any idea how to pinpoint the exact trigger, but it probably should be reported there |
2 participants
YouTube video previews seem to slow down my browser by a lot and I never use them.
Having the ability to disable this may be a benefit to all users who do not care about watching videos in the extension.