Open
Conversation
Contributor
🎯 Coverage Target Met!📈 Coverage Metrics
📊 Test Statistics
🔍 Files Needing Coverage
📝 Report generated on Node.js v24.13.1 • View workflow • Coverage by Vitest + v8 |
Contributor
domarmstrong
left a comment
domarmstrong
left a comment
There was a problem hiding this comment.
Well, I wasn't quite ready to put it up for review as I was planning on revisiting the API for the tools. But it's probably worth going ahead with and I can revisit after.
src/bugsnag/tool/error/get-error.ts
Outdated
Comment on lines
+57
to
+58
| (client: BugsnagClient) => async (args, _extra) => { | ||
| const params = args; |
Contributor
There was a problem hiding this comment.
Either rename the usages to args or rename the arg to params. Same for all the tools
Suggested change
| (client: BugsnagClient) => async (args, _extra) => { | |
| const params = args; | |
| (client: BugsnagClient) => async (params, _extra) => { |
Contributor
Author
There was a problem hiding this comment.
updated across the tools
| * type Output = typeof myTool.output; // typeof result | ||
| * ``` | ||
| */ | ||
| export class TypesafeTool< |
Contributor
There was a problem hiding this comment.
If this gets merged it would then we worth following up with all the other tools, removing the Tool class and renaming this to Tool.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Move bugsnag tools to use TypeSafeTool class from #368. No functional changes