[ZEPHYR] TM4J-14847: Add a new tool test execution update test steps#386
Open
[ZEPHYR] TM4J-14847: Add a new tool test execution update test steps#386
Conversation
Contributor
🎯 Coverage Target Met!📈 Coverage Metrics
📊 Test Statistics
🔍 Files Needing Coverage
📝 Report generated on Node.js v24.13.1 • View workflow • Coverage by Vitest + v8 |
assisblf
reviewed
Mar 20, 2026
Contributor
assisblf
left a comment
assisblf
left a comment
There was a problem hiding this comment.
Nice @BenzoEnzo! I added some comments
Comment on lines
+55
to
+71
| { | ||
| description: | ||
| "Mark the second step in test execution 'SA-E5' as failed (keep everything else unchanged).", | ||
| parameters: { | ||
| testExecutionIdOrKey: "SA-E5", | ||
| steps: [ | ||
| { | ||
| statusName: "Pass", | ||
| }, | ||
| { | ||
| statusName: "Fail", | ||
| }, | ||
| ], | ||
| }, | ||
| expectedOutput: | ||
| "The test execution steps are updated, but no output is expected.", | ||
| }, |
Contributor
There was a problem hiding this comment.
Accepting an incomplete list of steps could produce confusing scenarios. I'd recommend not dealing with incomplete steps, but we can discuss this internally with the PM if you're not sure.
Contributor
Author
There was a problem hiding this comment.
Sure, I will ask PM about that
Contributor
Author
There was a problem hiding this comment.
Hey @assisblf, Since we got a green light from the PM to add this capability, I added a part of logic to support updating a specific step. It conditionally builds the payload so only the intended fields are updated, while the rest remain unchanged.
…-test-steps' into TM4J-14847-test-execution-update-test-steps # Conflicts: # src/zephyr/tool/test-execution/update-test-steps.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR will provide functionality for updating a Test Execution Steps for user
Design
To be in line with things done for other Zephyr integrations, introduce PUT call type
Changeset
Testing