Fix: Prevent TOTP retry logic when no secret is present #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `send_top` function would previously attempt to retry a TOTP code if it failed, assuming that the 30-second window had expired. However, this logic would cause a `NameError` if the user had provided a 6-digit code instead of a TOTP secret. This commit fixes the issue by only attempting to retry the TOTP code if a `totp_secret` is available. Otherwise, the program will exit gracefully.
Fix TOTP Retry Logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send_topfunction would previously attempt to retry a TOTP codeif it failed, assuming that the 30-second window had expired. However,
this logic would cause a
NameErrorif the user had provided a 6-digitcode instead of a TOTP secret.
This commit fixes the issue by only attempting to retry the TOTP code
if a
totp_secretis available. Otherwise, the program will exitgracefully.