Conversation
deleteSensor, unregisterSensorFromRoom API를 @RequestParam으로 받도록 수정, getSensorBySerialNumber API 추가
방에 있는 각 센서마다 최근 1시간의 점수 데이터를 집계하여 평균 내서 구함
연관 엔티티 삭제 메서드 분리, HourlySnapshot 데이터도 함께 삭제되도록 수정, 연관된 방 평균 점수가 update되는 메서드 추가
Collaborator
Author
|
hourlysnapshot 관련 메서드 검토 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
센서를 삭제할 때 관련된 hourlysnapshot도 함께 삭제되도록 수정하였습니다.
센서 삭제 API, 방에서 센서 등록 해제 API의 파라미터를 @RequestBody -> @RequestParam으로 변경하였습니다.
HoulryDeviceAirQualityRepository -> HourlySensorAirQualityRepository로 이름을 변경하였습니다.
MqttReceiveService의 주석을 해제하였습니다.
ScoreScheduler의 주석을 해제하여 한 시간마다 방 평균 점수가 업데이트 되도록 하였습니다.
센서 일련번호로 센서 정보를 조회하는 API를 추가하였습니다.
CICD를 최적화하였습니다.
🛠️ PR 유형
어떤 변경 사항이 있나요?
💬 공유사항 to 리뷰어