Removed spaces after PHP close tag #233
Open
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blank line and spaces at the end of the file caused errors to be thrown such as: Warning: require(SteamConfig.php): failed to open stream: No such file or directory in ... Removing the 2 lines at the end fixes it.
Contributor
|
A newline at the end of a PHP script will not throw errors about missing files. |
Author
|
It's a new line with 4 blank spaces, which in some cases causes PHP errors. I've only had a few issues with it, but it's something that keeps getting reported to me and to fix it I have to get them to remove those 4 blank lines and the error disappears. |
Contributor
|
It's strange that this would be causing those errors for you, but either way +1 on the PR. Although wouldn't you be better off removing the entire closing php tag -?>
- |
Contributor
|
Can you provide a way to reproduce your problems? |
RedSparr0w
reviewed
Feb 15, 2019
| $steamprofile['uptodate'] = $_SESSION['steam_uptodate']; | ||
|
|
||
| // Version 4.0 | ||
| ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blank line and spaces at the end of the file caused errors to be thrown such as: Warning: require(SteamConfig.php): failed to open stream: No such file or directory in ...
Removing the line at the end of the file fixes this.